Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(op): ID token for device authorization grant #500

Merged
merged 6 commits into from
Dec 18, 2023
Merged

feat(op): ID token for device authorization grant #500

merged 6 commits into from
Dec 18, 2023

Conversation

muhlemmer
Copy link
Collaborator

@muhlemmer muhlemmer commented Dec 13, 2023 •
edited
Loading

This change allows returning of an ID Token in the Device Authorization grant,
when the openid scope is requested.
This is a non-standard add-on that crosses OpenID Connect with Oauth2 behavior.
Device Authorization grant is a Oauth2-only standard and therefore ID tokens are normally not part
of the grant type.

closes #426

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bca8833) 60.51% compared to head (45db180) 60.72%.

Files Patch % Lines
pkg/op/server_legacy.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
+ Coverage   60.51%   60.72%   +0.21%     
==========================================
  Files          78       78              
  Lines        6797     6813      +16     
==========================================
+ Hits         4113     4137      +24     
+ Misses       2386     2379       -7     
+ Partials      298      297       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muhlemmer muhlemmer mentioned this pull request Dec 15, 2023
Merged
13 tasks
@muhlemmer muhlemmer marked this pull request as ready for review December 15, 2023 22:29
@muhlemmer muhlemmer enabled auto-merge (squash) December 15, 2023 22:29
@muhlemmer muhlemmer merged commit b300027 into main Dec 18, 2023
8 checks passed
@muhlemmer muhlemmer deleted the feat-device-idtoken branch December 18, 2023 07:39
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@livio-a livio-a livio-a approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return an ID token with Device Authorizaiton
2 participants
@muhlemmer @livio-a